Add the onboarding surface variant to the expert components - #8439
Open
cstns wants to merge 3 commits into
Open
Conversation
cstns
changed the title
cstns
marked this pull request as ready for review
September 7, 2026 14:39
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8439 +/- ##
=======================================
Coverage 76.88% 76.88%
=======================================
Files 460 460
Lines 24741 24741
Branches 6596 6596
=======================================
Hits 19022 19022
Misses 5719 5719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cstns
force-pushed
the
8381-expert-surface-variant
branch
from
September 9, 2026 11:50
79e389a to
d3291e5
Compare
cstns
force-pushed
the
8381-expert-surface-variant
branch
from
September 9, 2026 14:15
d3291e5 to
75b8a06
Compare
cstns
force-pushed
the
8381-expert-surface-variant
branch
from
September 10, 2026 09:02
75b8a06 to
a2b69c9
Compare
cstns
force-pushed
the
8381-expert-surface-variant
branch
from
September 10, 2026 11:57
2d30728 to
f59c4db
Compare
cstns
force-pushed
the
8381-expert-surface-variant
branch
from
September 10, 2026 12:21
f59c4db to
b73cb4b
Compare
cstns
force-pushed
the
8381-expert-surface-variant
branch
from
September 10, 2026 12:26
b73cb4b to
b96a046
Compare
It had invented a composables folder inside the component tree. Composables live under frontend/src/composables, mirroring the path of whatever they are namespaced to, the way InstanceFormHelper sits under composables/Components/multi-step-forms/instance. The spec moves to test/unit/frontend/composables, flat, matching how the existing composable specs sit there regardless of source subdirectory. Also drops the explanatory comments on the onboarding branches in ExpertChatInput and ExpertMessages.
cstns
force-pushed
the
8381-expert-surface-variant
branch
from
September 10, 2026 13:07
b96a046 to
302223c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8381 / #8380, stacked on #8436. First of two PRs for the onboarding surface; the page that activates all of this comes in the next one.
This teaches the shared expert chat components an
expert-surfacevariant, injected with a'drawer'default so nothing changes anywhere until a surface provides'onboarding'. Under that variant:ExpertMessagesrenders through a new purebuildCollapsedTranscripthelper: past question turns (the AI questions message plus the composed human reply) fold intofolded-turnentries, the collapsing transcript treatment from the mockups on Build the onboarding UI #8380. The drawer path maps messages through unchanged.CollapsedQuestionTurnrenders the fold: one quiet line per question with the picks as pill chips (one chip per pick for multi selects), a Skipped marker for unanswered stale turns, expand/collapse to the original messages, and chip clicks loading the "question answer" line into the composer, since correcting a sent answer means sending a new message.Expert.vuehides the info banner and skips the canned welcome message (the Expert opens the onboarding conversation itself, Open the onboarding conversation without waiting for the user #8369).ExpertChatInputhides Start over, Plan mode and the settings cog, and reads "Or just tell me in your own words".Everything is inert without a provider, so the reviewable claim here is that the drawer rendering is byte identical. Covered by 12 unit tests over the fold helper and the folded turn component.